tendermint/vote/
canonical_vote.rs

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
use serde::{Deserialize, Serialize};
use tendermint_proto::v0_37::types::CanonicalVote as RawCanonicalVote;

use crate::{block, chain::Id as ChainId, prelude::*, Time};

/// CanonicalVote is used for protobuf encoding a Vote
#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq)]
#[serde(try_from = "RawCanonicalVote", into = "RawCanonicalVote")]
pub struct CanonicalVote {
    /// Type of vote (prevote or precommit)
    pub vote_type: super::Type,

    /// Block height
    pub height: block::Height,

    /// Round
    pub round: block::Round,

    /// Block ID
    //#[serde(deserialize_with = "serializers::parse_non_empty_block_id")] - moved to try_from
    pub block_id: Option<block::Id>,

    /// Timestamp
    pub timestamp: Option<Time>,

    /// Chain ID
    pub chain_id: ChainId,
}

tendermint_pb_modules! {
    use super::CanonicalVote;
    use crate::Error;
    use crate::{block, chain::Id as ChainId, prelude::*};
    use pb::types::CanonicalVote as RawCanonicalVote;

    impl Protobuf<RawCanonicalVote> for CanonicalVote {}

    impl TryFrom<RawCanonicalVote> for CanonicalVote {
        type Error = Error;

        fn try_from(value: RawCanonicalVote) -> Result<Self, Self::Error> {
            if value.timestamp.is_none() {
                return Err(Error::missing_timestamp());
            }
            let _val: i32 = value.round.try_into().map_err(Error::integer_overflow)?;

            // If the Hash is empty in BlockId, the BlockId should be empty.
            // See: https://github.com/informalsystems/tendermint-rs/issues/663
            let block_id = value.block_id.filter(|i| !i.hash.is_empty());
            Ok(CanonicalVote {
                vote_type: value.r#type.try_into()?,
                height: value.height.try_into()?,
                round: (value.round as i32).try_into()?,
                block_id: block_id.map(|b| b.try_into()).transpose()?,
                timestamp: value.timestamp.map(|t| t.try_into()).transpose()?,
                chain_id: ChainId::try_from(value.chain_id)?,
            })
        }
    }

    impl From<CanonicalVote> for RawCanonicalVote {
        fn from(value: CanonicalVote) -> Self {
            // If the Hash is empty in BlockId, the BlockId should be empty.
            // See: https://github.com/informalsystems/tendermint-rs/issues/663
            let block_id = value.block_id.filter(|i| i != &block::Id::default());
            RawCanonicalVote {
                r#type: value.vote_type.into(),
                height: value.height.into(),
                round: value.round.value().into(),
                block_id: block_id.map(Into::into),
                timestamp: value.timestamp.map(Into::into),
                chain_id: value.chain_id.to_string(),
            }
        }
    }
}

impl CanonicalVote {
    /// Create CanonicalVote from Vote
    pub fn new(vote: super::Vote, chain_id: ChainId) -> CanonicalVote {
        CanonicalVote {
            vote_type: vote.vote_type,
            height: vote.height,
            round: vote.round,
            block_id: vote.block_id,
            timestamp: vote.timestamp,
            chain_id,
        }
    }
}

#[cfg(test)]
mod tests {

    tendermint_pb_modules! {
        use tendermint_proto::google::protobuf::Timestamp;
        use pb::types::{
            CanonicalBlockId as RawCanonicalBlockId,
            CanonicalPartSetHeader as RawCanonicalPartSetHeader,
            CanonicalVote as RawCanonicalVote,
        };
        use crate::{
            prelude::*,
            vote::{canonical_vote::CanonicalVote, Type},
        };

        #[test]
        fn canonical_vote_domain_checks() {
            // RawCanonicalVote with edge cases to test domain knowledge
            // block_id with empty hash should decode to None
            // timestamp at EPOCH is still considered valid time
            let proto_cp = RawCanonicalVote {
                r#type: 1,
                height: 2,
                round: 4,
                block_id: Some(RawCanonicalBlockId {
                    hash: vec![],
                    part_set_header: Some(RawCanonicalPartSetHeader {
                        total: 1,
                        hash: vec![1],
                    }),
                }),
                timestamp: Some(Timestamp {
                    seconds: 0,
                    nanos: 0,
                }),
                chain_id: "testchain".to_string(),
            };
            let cp = CanonicalVote::try_from(proto_cp).unwrap();
            assert_eq!(cp.vote_type, Type::Prevote);
            assert!(cp.block_id.is_none());
            assert!(cp.timestamp.is_some());

            // No timestamp is not acceptable
            // See: https://github.com/informalsystems/tendermint-rs/issues/649
            let mut proto_cp: RawCanonicalVote = cp.into();
            proto_cp.timestamp = None;
            assert!(CanonicalVote::try_from(proto_cp).is_err());
        }
    }
}